Skip to content

Conversation

saumyaborwankar
Copy link
Contributor

@saumyaborwankar saumyaborwankar commented Feb 23, 2023

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added/updated (if possible)
  • Documentation has been updated/added if relevant

What is the current behavior?

There was a warning message:
image

What is the new behavior?

Removed the warning message by removing the flag in the install_site.sh file:
image
Closes #8728

Other information?

@saumyaborwankar saumyaborwankar marked this pull request as ready for review February 23, 2023 23:42
@saumyaborwankar saumyaborwankar changed the title [Bugfix:System] Removed deprecated --no-suggest from install_site.sh [Bugfix:System] Removed deprecated --no-suggest Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #8952 (0049bca) into main (907df66) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #8952   +/-   ##
=========================================
  Coverage     23.24%   23.24%           
  Complexity     7797     7797           
=========================================
  Files           220      220           
  Lines         27271    27271           
  Branches         70       70           
=========================================
  Hits           6340     6340           
  Misses        20863    20863           
  Partials         68       68           
Flag Coverage Δ
autograder 20.45% <ø> (ø)
js 28.47% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.19% <ø> (ø)
python_submitty_utils 71.65% <ø> (ø)
submitty_daemon_jobs 91.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MasterOdin MasterOdin merged commit a4768aa into Submitty:main Feb 24, 2023
@saumyaborwankar saumyaborwankar deleted the saumyaborwankar/issue8728 branch February 24, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning about depreciated feature used in submitty install script
2 participants