-
Notifications
You must be signed in to change notification settings - Fork 887
[Testing:Forum] Part replace of test_forum_merge_threads #9393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9393 +/- ##
=========================================
Coverage 23.31% 23.31%
Complexity 7972 7972
=========================================
Files 221 221
Lines 28386 28386
Branches 72 72
=========================================
Hits 6618 6618
Misses 21699 21699
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more. |
Should this be a draft? |
I am working to refactor these tests to be more like the tests in profile.spec.js (instead of duplicating code, making functions to call instead) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test seems reasonable to me, but I need to see the CI pass before I can approve. Please ping me or re-request a review when the tests are passing.
Please check if the PR fulfills these requirements:
What is the current behavior?
Selenium tests are flaky, so we are porting them to cypress.
What is the new behavior?
This is a basic forum test, which adds three different forum threads, comments to them, merges them into one, then deletes the resulting thread.