Skip to content

Conversation

IDzyre
Copy link
Contributor

@IDzyre IDzyre commented Jun 5, 2023

Please check if the PR fulfills these requirements:

What is the current behavior?

Selenium tests are flaky, so we are porting them to cypress.

What is the new behavior?

This is a basic forum test, which adds three different forum threads, comments to them, merges them into one, then deletes the resulting thread.

@IDzyre IDzyre changed the title forum tests [Testing:Forum] Replace test_forum_merge_threads Jun 5, 2023
@IDzyre IDzyre changed the title [Testing:Forum] Replace test_forum_merge_threads [Testing:Forum] First step to test_forum_merge_threads Jun 5, 2023
@IDzyre IDzyre changed the title [Testing:Forum] First step to test_forum_merge_threads [Testing:Forum] Partial replace of test_forum_merge_threads Jun 5, 2023
@IDzyre IDzyre changed the title [Testing:Forum] Partial replace of test_forum_merge_threads [Testing:Forum] Part replace of test_forum_merge_threads Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #9393 (536864d) into main (77f0006) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #9393   +/-   ##
=========================================
  Coverage     23.31%   23.31%           
  Complexity     7972     7972           
=========================================
  Files           221      221           
  Lines         28386    28386           
  Branches         72       72           
=========================================
  Hits           6618     6618           
  Misses        21699    21699           
  Partials         69       69           
Flag Coverage Δ
autograder 22.08% <ø> (ø)
js 28.01% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.29% <ø> (ø)
python_submitty_utils 71.65% <ø> (ø)
submitty_daemon_jobs 91.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mahi-pas
Copy link
Contributor

mahi-pas commented Jun 5, 2023

Should this be a draft?

@IDzyre IDzyre marked this pull request as draft June 6, 2023 04:35
@IDzyre IDzyre marked this pull request as ready for review June 6, 2023 20:34
@IDzyre IDzyre requested a review from williamjallen June 7, 2023 17:07
@IDzyre IDzyre marked this pull request as draft June 7, 2023 18:24
@IDzyre
Copy link
Contributor Author

IDzyre commented Jun 7, 2023

I am working to refactor these tests to be more like the tests in profile.spec.js (instead of duplicating code, making functions to call instead)

@IDzyre IDzyre marked this pull request as ready for review June 12, 2023 17:27
@IDzyre IDzyre requested a review from williamjallen June 15, 2023 18:03
Copy link
Member

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test seems reasonable to me, but I need to see the CI pass before I can approve. Please ping me or re-request a review when the tests are passing.

@IDzyre IDzyre requested a review from williamjallen June 21, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants