Skip to content

[UI/UX:System] User Preferred Locale Selection #9415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 79 commits into from
Aug 11, 2023
Merged

[UI/UX:System] User Preferred Locale Selection #9415

merged 79 commits into from
Aug 11, 2023

Conversation

skara9
Copy link
Contributor

@skara9 skara9 commented Jun 13, 2023 •
edited
Loading

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added/updated (if possible)
  • Documentation has been updated/added if relevant

This PR adds support for Submitty users to specify their own custom locale to view the site in.

image

skara9 added 30 commits March 21, 2023 16:18
@skara9
feat: locale data configuration
6d06590
@skara9
Merge branch 'main' into localization
0665a55
@skara9
fix: ensure lang dir is found before generating locale
e8d7200
@skara9
add default locale and lang dir to configuration script
5199fde
@skara9
fix prompt
dab2fe2
@skara9
php lint fix
95ae03e
@skara9
Update db_check.yml
097660c
@skara9
update tests for config
0789512
@skara9
remove locale dependence on config
9f983a9
@skara9
fix: mock lang file in config test
b471850
@skara9
fix config test
698eb88
@skara9
fix: add locale to configure submitty input
4f01f84
@skara9
load lang files to php
29c232f
@skara9
remove lang path from config and make sure locale is set
b4670dd
@skara9
update config tests for cached php lang
8784460
@skara9
remove slashes
2f0bdf8
@skara9
core lang method not prop
9f5bee2
@skara9
Merge branch 'main' into localization
05ed026
@skara9
php lint fix
d7b26be
@skara9
check for explicit null config
6665d76
@skara9
text fn
2e09eea
@skara9
php lint fix
20a6210
@skara9
Merge branch 'main' into localization
60448ff
@skara9
msgfmt
c3cef09
@skara9
php-intl
b9cb1c7
@skara9
rename text to localize
dbe8b62
@skara9
migration for user locale
a42d5d0
@skara9
sql dump
4402443
@skara9
user locale selection
e107d33
@skara9
set user locale
6783643
Base automatically changed from localization to main August 10, 2023 18:07
@skara9 skara9 force-pushed the user-locale branch 2 times, most recently from dbac702 to 9cf339b Compare August 10, 2023 18:15
@nia-gaeaf nia-gaeaf self-requested a review August 10, 2023 19:34
nia-gaeaf
nia-gaeaf approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@nia-gaeaf nia-gaeaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@nia-gaeaf nia-gaeaf changed the title [Feature:Lang] User Preferred Locale Selection [UI/UX:System] User Preferred Locale Selection Aug 10, 2023
@bmcutler bmcutler merged commit 3ec3726 into main Aug 11, 2023
@bmcutler bmcutler deleted the user-locale branch August 11, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcutler bmcutler bmcutler requested changes

@nia-gaeaf nia-gaeaf nia-gaeaf approved these changes

+1 more reviewer

@Youssef-Chip Youssef-Chip Youssef-Chip approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@skara9 skara9

Labels
Localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skara9 @bmcutler @nia-gaeaf @Youssef-Chip