Skip to content

[UI/UX:System] Peer Grading Submission Browser #9571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

musaabimran
Copy link
Contributor

@musaabimran musaabimran commented Jul 29, 2023

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added/updated (if possible)
  • Documentation has been updated/added if relevant
  • Screenshots are attached to Github PR if visual/UI changes were made

What is the current behavior?

The student grader cannot see the results folder so the button "Open/Close Results" shouldn't be there.
image

What is the new behavior?

Now the button is not visible to the student grader. Closes #9570
image

@musaabimran musaabimran requested a review from bmcutler July 29, 2023 14:11
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #9571 (1b10d09) into main (ae2661d) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #9571      +/-   ##
============================================
+ Coverage     23.16%   23.23%   +0.07%     
  Complexity     8086     8086              
============================================
  Files           226      215      -11     
  Lines         28894    27019    -1875     
  Branches         73       73              
============================================
- Hits           6692     6278     -414     
+ Misses        22132    20671    -1461     
  Partials         70       70              
Flag Coverage Δ
autograder ?
js 27.51% <ø> (ø)
migrator 100.00% <ø> (ø)
php 19.99% <ø> (ø)
python_submitty_utils 71.65% <ø> (ø)
submitty_daemon_jobs 91.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@musaabimran musaabimran linked an issue Jul 29, 2023 that may be closed by this pull request
@musaabimran musaabimran changed the title Peer Grading Submission Browser UI [UI/UX:Submssion] Peer Grading Submission Browser Jul 29, 2023
@musaabimran musaabimran changed the title [UI/UX:Submssion] Peer Grading Submission Browser [UI/UX:System] Peer Grading Submission Browser Jul 29, 2023
@musaabimran musaabimran self-assigned this Jul 30, 2023
@musaabimran musaabimran marked this pull request as ready for review July 30, 2023 06:57
@musaabimran musaabimran force-pushed the Submission-Panel-UI branch from 480ce28 to da9621a Compare July 30, 2023 07:03
Copy link
Contributor

@mahi-pas mahi-pas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for instructor, ta, grader, and student. All works properly. looked at the code and the changes make sense. LGTM

@bmcutler bmcutler merged commit 3b811d4 into Submitty:main Aug 2, 2023
@musaabimran musaabimran deleted the Submission-Panel-UI branch August 2, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peer Grading Submission Browser UI
3 participants