Skip to content

[Documentation:Developer] InstallationTroubleshooting VPN Problem #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

musaabimran
Copy link
Contributor

@musaabimran musaabimran commented Jun 5, 2023

This is the Error that occurs with people outside USA.

Screenshot_1

@musaabimran musaabimran requested a review from bmcutler June 5, 2023 10:18
@musaabimran musaabimran changed the title VPN- Error Installation-Troubleshooting VPN Problem Jun 5, 2023
@musaabimran musaabimran changed the title Installation-Troubleshooting VPN Problem [Documentation:Developer] InstallationTroubleshooting VPN Problem Jun 5, 2023
Copy link
Member

@bmcutler bmcutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you meant to delete the bundle config file & gemfile lock file. Please review the edits with this PR.

Also, I don't think the instructions to run 'vagrant provision' are useful in the general case.

@musaabimran
Copy link
Contributor Author

I don't think you meant to delete the bundle config file & gemfile lock file. Please review the edits with this PR.

Also, I don't think the instructions to run 'vagrant provision' are useful in the general case.

Yes we don't have to delete bundle config file & gemfile lock file. And I have replaced the 'vagrant provision' with 'vagrant up'

@musaabimran
Copy link
Contributor Author

Screenshot_1
This is the display result.

@musaabimran musaabimran requested a review from bmcutler June 13, 2023 11:01
@bmcutler
Copy link
Member

@musaabimran

When I view 'files changed', I still see that you have edited unnecessary files in this PR

Screenshot 2023-07-13 at 2 47 19 PM

Copy link
Member

@bmcutler bmcutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see note above

@musaabimran musaabimran force-pushed the Installation-Troubleshooting-Edit branch from cd2f3d3 to 5367b2a Compare July 14, 2023 11:01
@musaabimran musaabimran reopened this Jul 14, 2023
@musaabimran musaabimran requested a review from bmcutler July 14, 2023 13:44
@bmcutler bmcutler merged commit e143da2 into Submitty:main Jul 14, 2023
@musaabimran musaabimran self-assigned this Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants