Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

482 As a shop owner I can sell in USD currency #757

Merged
merged 163 commits into from
Oct 13, 2022

Conversation

chrisjsimpson
Copy link
Contributor

@chrisjsimpson chrisjsimpson commented Jan 10, 2022

Ref #482

Where to start?

ummm... im thinking of ways on how the template using jinjax should look like.

If a shop only use price list for promotion code, discount codes its easier to let the shop owner see in the dashboard>subscriber because all the plans are in the same currency.

UI considerations

a challenge will be when shop owners enable multi currency.
how we will express different currencies into the GUI.
for example,

  • filtering plans by currency having like categories (is this needed? User story needed)
  • showing the currency symbol and abbreviations (e.g. The Canadian dollar is the currency of Canada. It is abbreviated with the dollar sign $, or sometimes CA$, Can$ or C$ to distinguish it from other dollar-denominated currencies https://en.m.wikipedia.org/wiki/Canadian_dollar)

Upgrade path

  1. SUPPORTED_CURRENCIES to be added to shops .env e.g. https://github.com/Subscribie/subscribie/pull/757/files#diff-a3046da0d15a27e89f2afe639b25748a7ad4d9290af3e7b1b6c1a5533c8f0a8cR71
  2. Set default currency of existing shops (see https://github.com/Subscribie/subscribie/pull/757/files#diff-6ef88f6680b4d380b20fe45a1890c33097b419042fd5ed45ac6c748432dff3f8R72) (new shops should get have default currency set during sign-up based on geo location up
  • to set manually: update setting set default_currency="GBP"; (note manual setting of currency not required)

@github-actions
Copy link

🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk

@github-actions
Copy link

🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk

@chrisjsimpson chrisjsimpson changed the title 482 accept usd currency 482 As a shop owner I can sell in USD currency Mar 18, 2022
@github-actions
Copy link

🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk

@lgtm-com
Copy link

lgtm-com bot commented Mar 24, 2022

This pull request introduces 2 alerts when merging 441fab4 into 43e0bd9 - view on LGTM.com

new alerts:

  • 2 for Unused import

@chrisjsimpson chrisjsimpson added the enhancement New feature or request label Apr 20, 2022
@lgtm-com
Copy link

lgtm-com bot commented Apr 30, 2022

This pull request introduces 2 alerts when merging 6508bf4 into 251cf53 - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 12, 2022

This pull request introduces 2 alerts and fixes 9 when merging 5655f1f into b30bed8 - view on LGTM.com

new alerts:

  • 2 for Unused import

fixed alerts:

  • 4 for Unused import
  • 3 for Unused local variable
  • 2 for Variable defined multiple times

@github-actions
Copy link

🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk

@lgtm-com
Copy link

lgtm-com bot commented Oct 12, 2022

This pull request introduces 2 alerts and fixes 9 when merging d64e295 into aa014f8 - view on LGTM.com

new alerts:

  • 2 for Unused import

fixed alerts:

  • 4 for Unused import
  • 3 for Unused local variable
  • 2 for Variable defined multiple times

@github-actions
Copy link

🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk

@chrisjsimpson chrisjsimpson temporarily deployed to testing October 12, 2022 21:55 Inactive
@github-actions
Copy link

🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk

@lgtm-com
Copy link

lgtm-com bot commented Oct 12, 2022

This pull request introduces 2 alerts and fixes 9 when merging dc6cc19 into aa014f8 - view on LGTM.com

new alerts:

  • 2 for Unused import

fixed alerts:

  • 4 for Unused import
  • 3 for Unused local variable
  • 2 for Variable defined multiple times

@github-actions
Copy link

🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk

@lgtm-com
Copy link

lgtm-com bot commented Oct 13, 2022

This pull request introduces 2 alerts and fixes 9 when merging e5953f9 into a8478c2 - view on LGTM.com

new alerts:

  • 2 for Unused import

fixed alerts:

  • 4 for Unused import
  • 3 for Unused local variable
  • 2 for Variable defined multiple times

@joeltejeda joeltejeda merged commit 259ea4b into master Oct 13, 2022
@joeltejeda joeltejeda temporarily deployed to production October 13, 2022 21:07 Inactive
@github-actions
Copy link

🚀 PR was released in v0.1.121 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Oct 13, 2022
@joeltejeda
Copy link
Collaborator

#903 if a subscriber is from a US country the plan will change the currency to USD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants