-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
482 As a shop owner I can sell in USD currency #757
Conversation
…nnecting-stripe-internationally
…nnecting-stripe-internationally
… on stripe connect admin page
🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk |
🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk |
🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk |
This pull request introduces 2 alerts when merging 441fab4 into 43e0bd9 - view on LGTM.com new alerts:
|
…cept-usd-currency
This pull request introduces 2 alerts when merging 6508bf4 into 251cf53 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts and fixes 9 when merging 5655f1f into b30bed8 - view on LGTM.com new alerts:
fixed alerts:
|
…cept-usd-currency
…teps' into 482-accept-usd-currency
…ribie into 482-accept-usd-currency
🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk |
This pull request introduces 2 alerts and fixes 9 when merging d64e295 into aa014f8 - view on LGTM.com new alerts:
fixed alerts:
|
…ribie into 482-accept-usd-currency
🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk |
…ribie into 482-accept-usd-currency
🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk |
This pull request introduces 2 alerts and fixes 9 when merging dc6cc19 into aa014f8 - view on LGTM.com new alerts:
fixed alerts:
|
🙌 Live preview is here: http://482-accept-usd-currency.pcpink.co.uk |
This pull request introduces 2 alerts and fixes 9 when merging e5953f9 into a8478c2 - view on LGTM.com new alerts:
fixed alerts:
|
🚀 PR was released in |
#903 if a subscriber is from a US country the plan will change the currency to USD |
Ref #482
Where to start?
ummm... im thinking of ways on how the template using jinjax should look like.
If a shop only use price list for promotion code, discount codes its easier to let the shop owner see in the dashboard>subscriber because all the plans are in the same currency.
UI considerations
a challenge will be when shop owners enable multi currency.
how we will express different currencies into the GUI.
for example,
Upgrade path
SUPPORTED_CURRENCIES
to be added to shops.env
e.g. https://github.com/Subscribie/subscribie/pull/757/files#diff-a3046da0d15a27e89f2afe639b25748a7ad4d9290af3e7b1b6c1a5533c8f0a8cR71update setting set default_currency="GBP";
(note manual setting of currency not required)