Bundle kubernetes_metadata plugin with fix for Fluentd pod restarts #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-stencel
requested review from
frankreno,
kasia-kujawa,
perk-sumo,
pmalek-sumo and
sumo-drosiek
as code owners
perk-sumo
approved these changes
Nov 26, 2020
pmalek-sumo
approved these changes
Nov 26, 2020
Replicates changes from this PR on upstream: fabric8io/fluent-plugin-kubernetes_metadata_filter#267
andrzej-stencel
force-pushed
the
bundle-metadata-plugin
branch
from
f6a3beb
to
0ccadca
Compare
sumo-drosiek
approved these changes
Nov 27, 2020
Might help if we decide to switch back to using upstream at one moment.
The plugin version is already there in the fluent-plugin-kubernetes-metadata-filter.gemspec file. I've added information about the code's origin in the plugin's README for greater visibility. |
andrzej-stencel
added a commit
that referenced
this pull request
Nov 30, 2020
…1183) This change bundles the `kubernetes_metadata` Fluentd plugin from https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/ into our repo, as the upstream is not active and our [pull request there](fabric8io/fluent-plugin-kubernetes_metadata_filter#267) is not being merged despite being accepted. This code was copied from upstream at commit fabric8io/fluent-plugin-kubernetes_metadata_filter@84f66a8 on `master` branch from Oct 8th, 2020. On that commit, changes from the pull request fabric8io/fluent-plugin-kubernetes_metadata_filter#267 have been applied.
andrzej-stencel
added a commit
that referenced
this pull request
Dec 14, 2020
…1183) (#1193) This change bundles the `kubernetes_metadata` Fluentd plugin from https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/ into our repo, as the upstream is not active and our [pull request there](fabric8io/fluent-plugin-kubernetes_metadata_filter#267) is not being merged despite being accepted. This code was copied from upstream at commit fabric8io/fluent-plugin-kubernetes_metadata_filter@84f66a8 on `master` branch from Oct 8th, 2020. On that commit, changes from the pull request fabric8io/fluent-plugin-kubernetes_metadata_filter#267 have been applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bundles the
kubernetes_metadataFluentd plugin from https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/ into our repo, as the upstream is not active and our pull request there is not being merged despite being accepted.There are two commits in this PR: the first one bundles the plugin's sources from
master(at commit fabric8io/fluent-plugin-kubernetes_metadata_filter@84f66a8 from Oct 8), the second one incorporates changes from the pull request fabric8io/fluent-plugin-kubernetes_metadata_filter#267.Testing performed