Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chart): Allow passing extra args to otel logs stateful set #3076

Merged
merged 14 commits into from
Jun 6, 2023
Merged

feat(chart): Allow passing extra args to otel logs stateful set #3076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
260a8a4
initial commit
Jun 4, 2023
358ef9c
renaming change file
Jun 4, 2023
197321d
added details in readme
Jun 5, 2023
4e2cf99
added default value of otel sts args
Jun 5, 2023
b3c9780
fixed code styling
Jun 5, 2023
e3d836a
setting blank extraArgs
Jun 5, 2023
c9de8ab
rebase main branch
Jun 5, 2023
61103e0
renaming change file
Jun 4, 2023
d220195
added details in readme
Jun 5, 2023
bf7c26b
added default value of otel sts args
Jun 5, 2023
0fb4a58
fixed code styling
Jun 5, 2023
0895fc6
setting blank extraArgs
Jun 5, 2023
a20e97c
rebase main branch
Jun 5, 2023
e42f8b6
reveretd changefile
Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/3076.changed.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
feat: pass extra arguments to otel logs statefulset
1 change: 1 addition & 0 deletions deploy/helm/sumologic/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,7 @@ The following table lists the configurable parameters of the Sumo Logic chart an
| `metadata.logs.statefulset.extraVolumes` | Additional volumes for logs metadata enrichment (otelcol) pods. | `Nil` |
| `metadata.logs.statefulset.extraVolumeMounts` | Additional volume mounts for logs metadata enrichment (otelcol) pods. | `Nil` |
| `metadata.logs.statefulset.extraPorts` | Additional exposed ports in logs metadata enrichment (otelcol) pods and service. | `Nil` |
| `metadata.logs.statefulset.extraArgs` | Additional arguments to otelcol container. | `Nil` |
| `metadata.logs.autoscaling.enabled` | Option to turn autoscaling on for logs metadata enrichment (otelcol) and specify params for HPA. Autoscaling needs metrics-server to access cpu metrics. | `false` |
| `metadata.logs.autoscaling.minReplicas` | Default min replicas for autoscaling. | `3` |
| `metadata.logs.autoscaling.maxReplicas` | Default max replicas for autoscaling | `10` |
Expand Down
3 changes: 3 additions & 0 deletions deploy/helm/sumologic/templates/logs/otelcol/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ spec:
imagePullPolicy: {{ .Values.metadata.image.pullPolicy }}
args:
- --config=/etc/otel/config.yaml
{{- if .Values.metadata.logs.statefulset.extraArgs }}
{{ toYaml .Values.metadata.logs.statefulset.extraArgs | indent 10 }}
{{- end }}
resources:
{{- toYaml .Values.metadata.logs.statefulset.resources | nindent 10 }}
{{- if .Values.metadata.logs.statefulset.containers.otelcol.securityContext }}
Expand Down
1 change: 1 addition & 0 deletions deploy/helm/sumologic/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4050,6 +4050,7 @@ metadata:
# - name: otlphttp2
# containerPort: 4319
# protocol: TCP
# extraArgs:

## Option to turn autoscaling on for logs and specify params for HPA.
## Autoscaling needs metrics-server to access cpu metrics.
Expand Down
2 changes: 2 additions & 0 deletions tests/helm/testdata/goldenfile/metadata_logs_otc_statefulset/custom.input.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ metadata:
- name: otlphttp3
containerPort: 4320
protocol: TCP
extraArgs:
- --config=/etc/otel/test-config.yaml

## Option to turn autoscaling on for logs and specify params for HPA.
## Autoscaling needs metrics-server to access cpu metrics.
Expand Down
1 change: 1 addition & 0 deletions tests/helm/testdata/goldenfile/metadata_logs_otc_statefulset/custom.output.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ spec:
imagePullPolicy: IfNotPresent
args:
- --config=/etc/otel/config.yaml
- --config=/etc/otel/test-config.yaml
resources:
limits:
cpu: 2000m
Expand Down