feat(upgrade_to_v3): add migration for repository key for kube-prometheus-stack #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
force-pushed
the
drosiek-kube-prometheus-stack-repository
branch
from
17779c7
to
2e79c3b
Compare
| } | ||
|
|
||
| func Migrate(yamlV2 string) (yamlV3 string, err error) { | ||
| valuesV2, err := parseValues(yamlV2) |
There was a problem hiding this comment.
valuesV2 should be inputValues
| return "", fmt.Errorf("error parsing input yaml: %v", err) | ||
| } | ||
|
|
||
| valuesV3 := migrate(&valuesV2) |
There was a problem hiding this comment.
valuesV3 should be outputValues
swiatekm
approved these changes
Nov 29, 2022
| @@ -1,60 +0,0 @@ | |||
| package kubestatemetricscollectors | |||
There was a problem hiding this comment.
Why are you removing this test?
andrzej-stencel
suggested changes
Nov 29, 2022
sumo-drosiek
force-pushed
the
drosiek-kube-prometheus-stack-repository
branch
2 times, most recently
from
a05cb1b
to
dc78392
Compare
…heus-stack Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-kube-prometheus-stack-repository
branch
from
dc78392
to
ab27508
Compare
andrzej-stencel
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/2651/files