ci: fix dev workflows #1179
Merged
ci: fix dev workflows #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
github_actions
added 2 commits
June 28, 2023 10:28
swiatekm
force-pushed
the
fix/build/dev-workflow
branch
from
f022adc
to
4c8ef8e
Compare
| @@ -265,7 +265,7 @@ build-push-container-multiplatform-dev: REPO_URL = "$(OPENSOURCE_REPO_URL_DEV)" | |||
| build-push-container-multiplatform-dev: build-push-container-multiplatform | |||
|
|
|||
| .PHONY: push-container-manifest-dev | |||
| push-container-manifest-dev: REPO_URL="$(OPENSOURCE_REPO_URL_DEV)" | |||
| push-container-manifest-dev: REPO_URL = "$(OPENSOURCE_REPO_URL_DEV)" | |||
There was a problem hiding this comment.
This doesn't actually matter, but makes it clear this isn't bash assignment.
sumo-drosiek
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix building the dev container images. #1176 failed to make some necessary changes to the Makefile.
Also fix the stored artifact name for building the dev msi package. This was changed by the recent CI overhaul in #1172 .