Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make targets for building in docker + docs #10

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

pmalek-sumo
Copy link

This adds documentation to existing make targets: reflex-build and reflex-test as well as some documentation around them in comments.

Additionally there is a new target added: telegraf-in-docker which builds telegraf binary in a container, targeting host's architecture and OS and placing it in repository's root directory.

@pmalek-sumo pmalek-sumo self-assigned this Aug 26, 2020
@perk-sumo perk-sumo merged commit ea081e8 into master Aug 26, 2020
@pmalek-sumo pmalek-sumo deleted the add-make-target-for-building-in-docker branch August 26, 2020 17:12
@perk-sumo perk-sumo restored the add-make-target-for-building-in-docker branch August 26, 2020 17:13
@perk-sumo
Copy link

Sorry, my bad, this did not get merged. I wonder how to "reopen" it 🤔

@pmalek-sumo
Copy link
Author

Sorry, my bad, this did not get merged. I wonder how to "reopen" it 🤔

o.0 how? I mean .... what? You merged it... Github's is playing with us?

@perk-sumo
Copy link

I've recreated it as #13

Copy link

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants