Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better memory #42

Closed
wants to merge 8 commits into from
Closed

Better memory #42

wants to merge 8 commits into from

Conversation

bmeyers
Copy link
Contributor

@bmeyers bmeyers commented Jan 24, 2017

This addresses issue #35. A default instance of PVmodule now takes 56kB of RAM instead of 235kB.

Bennet Meyers and others added 8 commits July 25, 2013 16:25
Merge remote-tracking branch 'upstream/master'
…tire module. Can also still use len-1 list. Issue SunPower#33
…level setting as well.

Relaxed constraint on test_pvcell.test_calc_series to allow for change due to Numpy update.
… in memory. Identical cells within a single module point to the same object in memory.
@bmeyers
Copy link
Contributor Author

bmeyers commented Jan 24, 2017

I would like to implement a similar approach at the string and system level as well.

@mikofski
Copy link
Contributor

should we close this in favor of your new PR?

also please start your new PR, so that the build server will run and everyone can see your changes, thx :)

@bmeyers
Copy link
Contributor Author

bmeyers commented Jan 26, 2017

Yes, let's close. Sorry, I'm confused on the PR front. Are you asking me to do a pull request from bm-gh34-35 to upstream/master instead of to mikofski/gh34-35?

mikofski referenced this pull request in bmeyers/PVMismatch Jan 26, 2017
@bmeyers bmeyers closed this Jan 26, 2017
@mikofski
Copy link
Contributor

mikofski commented Jan 26, 2017

reference the new PR here, with a message like

closed in favor of PR #

and put the new pr in the <>, github will create the link automatically and put a link in the new PR too, then when peeps are looking through the history, trying to figure out where it all went wrong, they can say:

oh sh*t we should have kept that other PR, why did they switch fools!

@bmeyers
Copy link
Contributor Author

bmeyers commented Jan 26, 2017

closed in favor of PR #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants