-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better memory #42
Better memory #42
Conversation
Merge remote-tracking branch 'upstream/master'
…tire module. Can also still use len-1 list. Issue SunPower#33
…level setting as well. Relaxed constraint on test_pvcell.test_calc_series to allow for change due to Numpy update.
Syncing up with main version
… in memory. Identical cells within a single module point to the same object in memory.
I would like to implement a similar approach at the string and system level as well. |
should we close this in favor of your new PR? also please start your new PR, so that the build server will run and everyone can see your changes, thx :) |
Yes, let's close. Sorry, I'm confused on the PR front. Are you asking me to do a pull request from bm-gh34-35 to upstream/master instead of to mikofski/gh34-35? |
…setting a whole module with one Ee.
reference the new PR here, with a message like
and put the new pr in the <>, github will create the link automatically and put a link in the new PR too, then when peeps are looking through the history, trying to figure out where it all went wrong, they can say:
|
closed in favor of PR #43 |
This addresses issue #35. A default instance of PVmodule now takes 56kB of RAM instead of 235kB.