Skip to content

Conversation

estahn
Copy link
Contributor

@estahn estahn commented May 16, 2017

Our Cloudformation stacks get stuck for 1 hour if the javascript code contains errors. In order to prevent this lambda-formation should catch errors on project level and information CF.

Example:

2017-05-16T04:41:28.643Z    c47b3600-39f1-11e7-ae9c-e103c4f2d375    ReferenceError: aws is not defined
at update (/var/task/lib/resources/HostedZone/update.js:10:23)
at Object.module.exports (/var/task/node_modules/lambda-formation/lib/resource/update.js:16:12)
at Object.module.exports.handler (/var/task/lib/resources/HostedZone/update.js:24:13)
at Object.module.exports (/var/task/node_modules/lambda-formation/lib/resource/handler.js:36:24)
at Object.module.exports.handler (/var/task/lib/resources/HostedZone/index.js:4:19)
at handler (/var/task/node_modules/lambda-formation/lib/project/handler.js:41:49)
at module.exports.handler (/var/task/index.js:5:18)

@coveralls
Copy link

coveralls commented May 16, 2017

Coverage Status

Coverage decreased (-0.8%) to 99.237% when pulling cdffea1 on estahn:catch-global-errors into d967b23 on SungardAS:master.

@coveralls
Copy link

coveralls commented May 16, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 70b1907 on estahn:catch-global-errors into d967b23 on SungardAS:master.

@kmcgrath kmcgrath self-assigned this May 16, 2017
@kmcgrath kmcgrath merged commit 90176ea into SungardAS:master May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants