Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional data fields to superdarn_radars.py #19

Merged
merged 6 commits into from
Dec 4, 2019
Merged

Added additional data fields to superdarn_radars.py #19

merged 6 commits into from
Dec 4, 2019

Conversation

DannoPeters
Copy link
Member

geographic: Named Tuple containing geographic latitude longitude and boresight
geomagnetic: Named Tuple containing geomagnetic latitude longitude and boresight
decommissioned: date radar was decommissioned (shut down)
commissioned: date radar was officially commissioned (data considered stable)
beamSep: angular separation between radar beams

geographic: Named Tuple containing geographic latitude longitude and boresight
geomagnetic: Named Tuple containing geomagnetic latitude longitude and boresight
decommissioned: date radar was decommissioned (shut down)
commissioned: date radar was officially commissioned (data considered stable)
beamSep: angular separation between radar beams
@DannoPeters DannoPeters self-assigned this Aug 26, 2019
Copy link
Contributor

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of whether we go forward with my suggestion, the docstring and variables should match.

pydarn/plotting/superdarn_radars.py Show resolved Hide resolved
pydarn/plotting/superdarn_radars.py Outdated Show resolved Hide resolved
pydarn/plotting/superdarn_radars.py Outdated Show resolved Hide resolved
pydarn/plotting/superdarn_radars.py Outdated Show resolved Hide resolved
@mts299 mts299 changed the base branch from plotting/rtp to io/update_DARNIO December 2, 2019 21:27
@mts299 mts299 changed the base branch from io/update_DARNIO to develop December 2, 2019 21:27
@mts299
Copy link
Contributor

mts299 commented Dec 2, 2019

Moving merge to develop since we don't have plotting/rtp anymore. I would like to also use this for my summary generation plots.

@mts299
Copy link
Contributor

mts299 commented Dec 2, 2019

Will test this tomorrow, just cleaned up the file to meet PEP8 standards.
If @aburrell if you are good with my suggestion on altitude then I will merge it tomorrow after my testing.

I would like to move this to develop ASAP so I can use it in my summary plot generation scripts.

@mts299
Copy link
Contributor

mts299 commented Dec 3, 2019

Did this test in the python interpreter:

python 
Python 3.6.9 (default, Oct 29 2019, 10:39:36) [GCC] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pydarn 
>>> pydarn.SuperDARNRadars
<class 'pydarn.plotting.superdarn_radars.SuperDARNRadars'>
>>> pydarn.SuperDARNRadars.radars[65]
_Radar(name='Rankin Inlet', stid=65, abbrev='rkn', beams=16, gates=100, geographic=_Coord(lat=59.6, lon=-64.3, bore=-16.2), geomagnetic=_Coord(lat=72.6, lon=-26.4, bore=1.8), hemisphere=<_Hemisphere.North: 1>, institute='University of Saskatchewan', decommissioned=None, commissioned=datetime.datetime(2007, 5, 1, 0, 0), beamSep=3.24)
>>> pydarn.SuperDARNRadars.radars[65].beams
16
>>> pydarn.SuperDARNRadars.radars[65].geographic
_Coord(lat=59.6, lon=-64.3, bore=-16.2)
>>> pydarn.SuperDARNRadars.radars[65].hemisphere
<_Hemisphere.North: 1>
>>> pydarn.SuperDARNRadars.radars[12].hemisphere
<_Hemisphere.South: -1>
>>> pydarn.SuperDARNRadars.radars[12].name
'Syowa South'

@mts299
Copy link
Contributor

mts299 commented Dec 4, 2019

Merging code, and will be making an issue on adding the altitude to this file for the future.

@mts299 mts299 merged commit 13b397d into develop Dec 4, 2019
@mts299 mts299 added this to the v1.0.0 milestone Jan 3, 2020
@mts299 mts299 deleted the geo branch January 6, 2020 17:29
mts299 added a commit that referenced this pull request Feb 5, 2020
Added additional data fields to superdarn_radars.py
mts299 added a commit that referenced this pull request Feb 26, 2020
Added additional data fields to superdarn_radars.py
mts299 added a commit that referenced this pull request Feb 26, 2020
Added additional data fields to superdarn_radars.py
mts299 added a commit that referenced this pull request Feb 26, 2020
Added additional data fields to superdarn_radars.py
mts299 added a commit that referenced this pull request Feb 26, 2020
Added additional data fields to superdarn_radars.py
mts299 added a commit that referenced this pull request Mar 25, 2020
Added additional data fields to superdarn_radars.py
mardet987 pushed a commit that referenced this pull request Mar 26, 2020
Added additional data fields to superdarn_radars.py

Former-commit-id: 13b397d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants