Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Climbing ladder underwater weirdly offsets Tux #2981

Closed
weluvgoatz opened this issue Jun 22, 2024 · 4 comments · Fixed by #3017
Closed

Climbing ladder underwater weirdly offsets Tux #2981

weluvgoatz opened this issue Jun 22, 2024 · 4 comments · Fixed by #3017
Labels
difficulty:easy good first issue Good for first-time contributors type:bug

Comments

@weluvgoatz
Copy link
Member

If you, for whatever reason, press up on a ladder that is underwater, Tux will be pushed to the left or right for whatever reason.
@weluvgoatz weluvgoatz added type:bug difficulty:easy good first issue Good for first-time contributors labels Jun 22, 2024
@MatusGuy
Copy link
Member

MatusGuy commented Jul 5, 2024

You should just not be able to climb underwater, right?

@weluvgoatz
Copy link
Member Author

Correct

@Brockengespenst
Copy link
Contributor

Climbing while swimming should already be blocked. A quick test in a self created level with the latest git state did not show any weird behavior, maybe a special setup is needed to reproduce this? Does this happen in an official level or could you provide a test level to reproduce the behavior?

@Brockengespenst
Copy link
Contributor

Ah Ok, I see. There is some code in Climbable that affects Tux as well. I'll create a PR that should prevent this.

@Brockengespenst Brockengespenst mentioned this issue Jul 13, 2024
Merged
Rusty-Box pushed a commit that referenced this issue Aug 30, 2024
@Brockengespenst
Prevent Tux from climbing while swimming (#3017)
d0b492a 
Climbable did not check if Tux is swimming and thus affects Tux's velocity. A check for is_swimming() is added to prevent this.

Fixes #2981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy good first issue Good for first-time contributors type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent Tux from climbing while swimming Brockengespenst/supertux
3 participants
@weluvgoatz @MatusGuy @Brockengespenst