Squirrel: Fix inaccessible class member variables, improvements #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in simplesquirrel, which caused exposed class member variables to be inaccessible from Squirrel. Additionally, simplesquirrel now supports custom getters and setters for class member variables. Because of this, more `get_` and `set_` functions of objects now have an alternative variable, which can also be used. All `get_` and `set_` functions which were made obsolete by member variables are now un-deprecated, because of a noticeable preference amongst scripters to keep both options available for convenience.
Vankata453
added
type:feature
category:code
involves:scripting
status:needs-review
|
I happen to notice that |
|
It just does that. |
|
ohhhhhhhhhhhhhhhhhhh wait huh Odd quirk, but at least nothings wrong. You can disregard what I said. |
tylerandari13
approved these changes
Jul 31, 2024
tobbi
reviewed
Jul 31, 2024
[ci skip]
[ci skip]
[ci skip]
MatusGuy
reviewed
Aug 10, 2024
|
Try using some variables that use getters and setters. Make sure variables as a whole work properly. |
MatusGuy
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in simplesquirrel, which caused exposed class member variables to be inaccessible from Squirrel.
Additionally:
get_andset_functions of objects now have an alternative variable, which can also be used.get_andset_functions which were made obsolete by member variables are now un-deprecated, because of a noticeable preference amongst scripters to keep both options available for convenience.