Skip to content

Conversation

perrinjerome
Copy link
Contributor

Method on parent class ( xmlrpclib.Transport.close ) expect connection to be
self._connection[1], but SupervisorTransport use self.connection for the
socket. Implement SupervisorTransport.close which uses self.connection.

Fixes #1184

Method on parent class ( xmlrpclib.Transport.close ) expect connection to be
self._connection[1], but SupervisorTransport use self.connection for the
socket. Implement SupervisorTransport.close which uses self.connection.
@perrinjerome
Copy link
Contributor Author

for reference, ServerProxy.close calls Transport.close, which implementation is

@mnaberez mnaberez merged commit 40e04ab into Supervisor:master Dec 22, 2018
mnaberez added a commit that referenced this pull request Dec 22, 2018
jleveque pushed a commit to jleveque/supervisor that referenced this pull request Mar 20, 2019
mnaberez added a commit that referenced this pull request Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

SupervisorTransport does not close connections

2 participants