Skip to content

onlineManager listeners only called when using setOnline(true) #85

@pzcfg

Description

@pzcfg

We have custom logic in our app that uses setOnline(false) if our server isn't reachable. We were running into issues trying to react to this with onlineManager, and it seems the reason for this is that onOnline() (which calls the listeners) is only called when setOnline() is called with a truthy value.

Screen Shot 2022-04-21 at 4 19 52 PM

This is different from the window's online status, which calls onOnline() for both online and offline events, so this seems like a bug.

Screen Shot 2022-04-21 at 4 25 08 PM

The listeners should either be called both when going online and offline, or there should be an additional way to listen for going offline.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions