Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test expectations #36

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Update test expectations #36

merged 1 commit into from
Mar 7, 2024

Conversation

teunbrand
Copy link
Contributor

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break platetools.

Briefly, a few tests expected ggplot objects to satisfy some length and name criterions that no longer hold in the new version. In this PR, these are updated to be aligned with whatever ggplot() returns, which works for both the old and new versions.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help platetools get out a fix if necessary.

@teunbrand
Copy link
Contributor Author

This is just a reminder that the release of ggplot2 is scheduled soon.

@Swarchal Swarchal merged commit 6022956 into Swarchal:master Mar 7, 2024
@teunbrand teunbrand deleted the ggplot2_3.5.0 branch March 7, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants