Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RollCall_footer #149

Closed
wants to merge 4 commits into from
Closed

RollCall_footer #149

wants to merge 4 commits into from

Conversation

Abhishekkr93
Copy link

@Abhishekkr93 Abhishekkr93 commented Apr 6, 2021

Related Issuse

  • Added Footer for Rollcall Website(sections that include here e.g. Copyright, Social media, T&C)

Closes: #118

Describe the changes you've made

Added code of Footer Section for Rollcall Website via Rollcall_footer file with index.html and style.css
Footer (sections that include here e.g. Copyright, Social media, T&C.)

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

Screenshots

| changes |
signal-2021-04-06-183043

Swarnimashukla and others added 4 commits April 5, 2021 12:13
Added folders where pics for detection of faces and then cropped faces will be stored
* Create issue.yml

* Update issue.yml
@Abhishekkr93 Abhishekkr93 mentioned this pull request Apr 6, 2021
@Swarnimashukla Swarnimashukla linked an issue Apr 6, 2021 that may be closed by this pull request
Copy link
Collaborator

@SKAUL05 SKAUL05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhishekkr93 I see some changes in workflow and python files in this PR.
I don't think u need to change them, pls check your PR again and only include relevant files.

@Abhishekkr93
Copy link
Author

In which file sir?
No sir, I only made a folder rollcall_footer then I added two file name index.html & style.css?

So, I need to make a fresh pull request now? @SKAUL05

@SKAUL05
Copy link
Collaborator

SKAUL05 commented Apr 8, 2021

@Abhishekkr93 It's showing around 28 files changed.
Either you can remove changes to the unknown files or create a new PR

@Abhishekkr93
Copy link
Author

okay sir, I will make a new PR. closing this. @SKAUL05

@Abhishekkr93
Copy link
Author

will making new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer for RollCall
4 participants