Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for toml 1.0? #163

Closed
epage opened this issue Aug 14, 2023 · 5 comments
Closed

No support for toml 1.0? #163

epage opened this issue Aug 14, 2023 · 5 comments

Comments

@epage
Copy link

epage commented Aug 14, 2023

I noticed the following in my CI logs:

Error parsing Cargo.toml manifest, fallback to caching entire file: SyntaxError: Expected "=", [ \t] or [A-Za-z0-9_-] but "." found.

See https://github.com/crate-ci/typos/actions/runs/5860151411

I'm assuming this is from doing edition.workspace = true which is valid toml.

@NobodyXu
Copy link
Contributor

It seems that the tml 3.0.0 in JS doesn't support toml 1.0, but the cache will still works.

Duplicate #162

@epage
Copy link
Author

epage commented Aug 14, 2023

Ah, missed that in my search; thanks!

Might help if the title or description summarized things.

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2023
@NobodyXu
Copy link
Contributor

Do you know any other toml parsing package in JS?

All packages I've found are old.

@epage
Copy link
Author

epage commented Aug 15, 2023

The TOML spec repo links out to parsers that claim to be 1.0.0 compliant: https://github.com/toml-lang/toml/wiki#implementations

If that falls through, we can always look at doing bindings for toml

@NobodyXu
Copy link
Contributor

Thanks, I will try replacing the existing toml dependency with one of them.

Swatinem pushed a commit that referenced this issue Aug 19, 2023
Fixed #162 #163

The former is listed on
https://github.com/toml-lang/toml/wiki#implementations and is toml 1.0
compliant.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants