[android] Remove SunSoft libm dependencies #18
Conversation
SunSoft libm dependencies introduce licensing issues when considering merging this fork upstream. Remove them for Android-only. In order to do so, we must also remove the reference to `log2` in `stdlib/public/core/BuiltinMath.swift,gyb`. Conditionally remove that reference by passing an additional parameter to the gyb template.
|
I'll add a test that uses |
|
Actually, we may be able to get |
|
Fixed in 4a39bc6! |
|
Does this mean we can't run on Android 4.4 and below? That's like half the Android devices out there: http://developer.android.com/about/dashboards/index.html Note that the SunSoft libm was originally taken from NDK's support library - I wonder if statically linking it would be acceptable. |
Yeah... I'm aware of the tradeoff, but I think it's the right one to make. Sending a pull request for the work we have here could benefit the greater community. We could then try and support Android 4.4 and below as a future improvement. Making this change now doesn't prevent that work from being done in the future. |
Android NDK version 21 includes log2 and getline, two dependencies whose licences prevented us from upstreaming the Android fork. Update to 21 in order to resolve these dependency issues.
SunSoft libm dependencies introduce licensing issues when considering merging this fork upstream. Remove them for Android only. In order to do so, we must also remove the reference to
log2instdlib/public/core/BuiltinMath.swift,gyb. Conditionally remove that reference by passing an additional parameter to the gyb template.