Skip to content

Styling #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025
Merged

Styling #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Public/css/highlight.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@
color: #c0c;
}

.exp-error {
background: #d22;
.exp-syntax-error {
border-top: solid 2px #d22;
}

span.match-char {
Expand Down
2 changes: 1 addition & 1 deletion Public/js/views/expression_field.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class ExpressionField extends EventDispatcher {
this.highlighter.clearError();
}

tippy(".exp-error", {
tippy(".exp-syntax-error", {
allowHTML: true,
animation: false,
placement: "bottom",
Expand Down
11 changes: 7 additions & 4 deletions Public/js/views/expression_highlighter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,17 +74,20 @@ export default class ExpressionHighlighter extends EventDispatcher {
error.location.end - error.location.start
);
const widget = document.createElement("span");
widget.className = `${pre}-error`;
widget.className = `${pre}-syntax-error`;

widget.style.height = `2px`;
widget.style.height = `5px`;
widget.style.zIndex = "10";
widget.setAttribute("data-tippy-content", error.message);
widget.setAttribute(
"data-tippy-content",
`<span class="fw-bolder text-danger">${error.behavior}:</span> ${error.message}`
);

editor.addWidget(location.startPos, widget);
const startCoords = editor.charCoords(location.startPos, "local");
const endCoords = editor.charCoords(location.endPos, "local");
widget.style.left = `${startCoords.left + 1}px`;
widget.style.top = `${startCoords.bottom}px`;
widget.style.top = `${startCoords.bottom - 1}px`;
widget.style.width = `${endCoords.left - startCoords.left - 2}px`;

this.widgets.push(widget);
Expand Down