Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: a bunch of dependency updates #544

Merged
merged 13 commits into from
Feb 11, 2021
Merged

chore: a bunch of dependency updates #544

merged 13 commits into from
Feb 11, 2021

Conversation

ableuler
Copy link
Contributor

@ableuler ableuler commented Feb 10, 2021

One of them patches a vulnerability.

/deploy

@@ -1,13 +1,11 @@
FROM python:3.7-alpine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ableuler why are we changing the base image? Was this also a security vulnerability?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependabot upgraded the cryptography package which doesn't play well with the alpine based image (we'd have to add a rust compiler). After switching to the debian based python image the package is pip-installable again. But I quickly wanted to try with the -slim base image and compare sizes, should have labeled it as WIP.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The slim image is actually smaller than the resulting alpine image with the necessary installs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double win 🥇

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-nb-544.dev.renku.ch

@ableuler ableuler temporarily deployed to renku-ci-nb-544 February 10, 2021 13:30 Inactive
@ableuler ableuler changed the title chore: a bunch of dependency updates [wip] chore: a bunch of dependency updates Feb 11, 2021
@ableuler ableuler temporarily deployed to renku-ci-nb-544 February 11, 2021 08:22 Inactive
@ableuler ableuler temporarily deployed to renku-ci-nb-544 February 11, 2021 09:08 Inactive
dependabot bot and others added 12 commits February 11, 2021 10:28
Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4.
- [Release notes](https://github.com/yaml/pyyaml/releases)
- [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES)
- [Commits](yaml/pyyaml@5.3.1...5.4)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.4 to 5.4.1.
- [Release notes](https://github.com/yaml/pyyaml/releases)
- [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES)
- [Commits](yaml/pyyaml@5.4...5.4.1)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.2 to 1.26.3.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/1.26.3/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.2...1.26.3)

Signed-off-by: dependabot[bot] <support@github.com>
@ableuler ableuler temporarily deployed to renku-ci-nb-544 February 11, 2021 09:28 Inactive
@ableuler ableuler changed the title [wip] chore: a bunch of dependency updates chore: a bunch of dependency updates Feb 11, 2021
@ableuler ableuler temporarily deployed to renku-ci-nb-544 February 11, 2021 10:13 Inactive
@ableuler ableuler deployed to renku-ci-nb-544 February 11, 2021 10:56 Active
@ableuler
Copy link
Contributor Author

anybody feels like approving the PR? :)

@rokroskar
Copy link
Member

ah sorry, I was waiting for acceptance tests to finish.. and then it was lunchtime 👍 😄

@ableuler ableuler merged commit e543ccc into master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants