-
Notifications
You must be signed in to change notification settings - Fork 24
[AdminUi] Add a Twig global variable for the context #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f303a19
to
db48a0b
Compare
db48a0b
to
1c68ed0
Compare
'@symfony/ux-live-component' => [ | ||
'path' => './vendor/symfony/ux-live-component/assets/dist/live_controller.js', | ||
], | ||
'tom-select/dist/css/tom-select.bootstrap4.css' => [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's automatical now, after the composer install. Here, it's only on the test application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should both Context and RoutingContext have interfaces? In case I would want to override those classes at end-user projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want user to change those contexts for now. That's only to bring access to admin ui configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either interfaces or some other extension point would be great, but yeah, it could be added at a later date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but before adding some extension point, it's preferable to be stable on data accessors. I think I need to add login path and things like that before. Or just adding the interface on the main context class.
I really didn't think it through; we can use the routes provided now. |
Add a better DX for the admin ui context.
Then, we have an autocompletion on our IDE.
