Add tests for external routing files #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Jun 17, 2025
loic425
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | partially #1029 |
| License | MIT |
diimpp
approved these changes
Jun 17, 2025
| public function buildGrid(GridBuilderInterface $gridBuilder): void | ||
| { | ||
| $gridBuilder | ||
| ->orderBy('fullName', 'asc') |
There was a problem hiding this comment.
Will it work since it's not a real doctrine field? Or it specifies grid field fullName default sorting?
There was a problem hiding this comment.
It's kind of decoupled yes. We just need a field with that id. I think that grid is cominng from the Sylius stack test application. I've reused an existing PoC code.
| public function it_allows_browsing_speakers(): void | ||
| { | ||
| SpeakerFactory::new() | ||
| ->withFirstName('Francis') |
There was a problem hiding this comment.
Can Francis sue sylius for becoming test data? 😂
There was a problem hiding this comment.
He's already on Sylius stack phpunit tests where this test is inspired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.