Imageserver fixes: single-thread object fetching and block replication clients during startup. #545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The imageserver was concurrently downloading objects during initial replication. If the same object was being downloaded concurrently, this could lead to failures:
Fixed this by single-threading object downloads from the replication master. This is also more friendly to the master.
A rebuilt (empty) imageserver which was both a replication client and master (to other downstream clients) would cause the downstream clients to delete all their images while it fetches images from its master. Fixed this by blocking replication clients until all images fetched from master (upstream).