Skip to content

CompatHelper: bump compat for SymbolicUtils in [weakdeps] to 2, (keep existing compat) #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the SymbolicUtils package from 0.19, ^1.0.5 to 0.19, ^1.0.5, 2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@coveralls
Copy link

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9410183441

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.35%

Totals Coverage Status
Change from base Build 9359402360: 0.0%
Covered Lines: 1866
Relevant Lines: 1957

💛 - Coveralls

@MilesCranmer MilesCranmer merged commit 4e8941e into master Jun 7, 2024
10 checks passed
@MilesCranmer MilesCranmer deleted the compathelper/new_version/2024-05-29-01-06-39-039-00781124978 branch June 7, 2024 01:45
Copy link
Contributor Author

github-actions bot commented Jun 7, 2024

Benchmark Results

master 27d2d83... master/27d2d83f0ec892...
eval/ComplexF32/evaluation 7.49 ± 0.46 ms 7.47 ± 0.46 ms 1
eval/ComplexF64/evaluation 9.64 ± 0.73 ms 9.76 ± 0.66 ms 0.988
eval/Float32/derivative 11.2 ± 2.4 ms 11.2 ± 2.2 ms 1
eval/Float32/derivative_turbo 11.3 ± 2.4 ms 11.2 ± 2.2 ms 1.01
eval/Float32/evaluation 2.77 ± 0.23 ms 2.75 ± 0.23 ms 1.01
eval/Float32/evaluation_bumper 0.534 ± 0.013 ms 0.558 ± 0.013 ms 0.956
eval/Float32/evaluation_turbo 0.758 ± 0.051 ms 0.718 ± 0.025 ms 1.05
eval/Float32/evaluation_turbo_bumper 0.537 ± 0.013 ms 0.558 ± 0.012 ms 0.963
eval/Float64/derivative 14.8 ± 0.55 ms 15.1 ± 0.53 ms 0.984
eval/Float64/derivative_turbo 14.8 ± 0.51 ms 15.1 ± 0.47 ms 0.982
eval/Float64/evaluation 2.93 ± 0.23 ms 2.91 ± 0.25 ms 1.01
eval/Float64/evaluation_bumper 1.2 ± 0.044 ms 1.2 ± 0.044 ms 0.997
eval/Float64/evaluation_turbo 1.22 ± 0.053 ms 1.21 ± 0.056 ms 1
eval/Float64/evaluation_turbo_bumper 1.21 ± 0.043 ms 1.2 ± 0.042 ms 1.01
utils/combine_operators/break_sharing 0.0412 ± 0.0013 ms 0.0413 ± 0.0013 ms 0.998
utils/convert/break_sharing 28.5 ± 1.1 μs 28.3 ± 1.1 μs 1.01
utils/convert/preserve_sharing 0.13 ± 0.0033 ms 0.128 ± 0.0032 ms 1.02
utils/copy/break_sharing 29.5 ± 1.1 μs 29.3 ± 1.2 μs 1.01
utils/copy/preserve_sharing 0.129 ± 0.0032 ms 0.129 ± 0.0033 ms 1
utils/count_constants/break_sharing 10.6 ± 0.16 μs 10.1 ± 0.15 μs 1.05
utils/count_constants/preserve_sharing 0.114 ± 0.0028 ms 0.112 ± 0.0022 ms 1.02
utils/count_depth/break_sharing 17.7 ± 0.58 μs 17.4 ± 0.35 μs 1.01
utils/count_nodes/break_sharing 9.97 ± 0.16 μs 9.71 ± 0.16 μs 1.03
utils/count_nodes/preserve_sharing 0.117 ± 0.0026 ms 0.116 ± 0.0023 ms 1.01
utils/get_set_constants!/break_sharing 0.0532 ± 0.00084 ms 0.0529 ± 0.0008 ms 1.01
utils/get_set_constants!/preserve_sharing 0.329 ± 0.007 ms 0.322 ± 0.0057 ms 1.02
utils/has_constants/break_sharing 4.42 ± 0.22 μs 4.58 ± 0.21 μs 0.964
utils/has_operators/break_sharing 1.75 ± 0.025 μs 2.09 ± 0.016 μs 0.837
utils/hash/break_sharing 0.0324 ± 0.0005 ms 0.0327 ± 0.0005 ms 0.992
utils/hash/preserve_sharing 0.136 ± 0.0032 ms 0.135 ± 0.0021 ms 1.01
utils/index_constants/break_sharing 27.8 ± 0.72 μs 27.5 ± 0.78 μs 1.01
utils/index_constants/preserve_sharing 0.13 ± 0.0031 ms 0.134 ± 0.0023 ms 0.97
utils/is_constant/break_sharing 4.78 ± 0.22 μs 4.43 ± 0.21 μs 1.08
utils/simplify_tree/break_sharing 0.154 ± 0.015 ms 0.154 ± 0.015 ms 1
utils/simplify_tree/preserve_sharing 0.271 ± 0.018 ms 0.306 ± 0.017 ms 0.887
utils/string_tree/break_sharing 0.398 ± 0.012 ms 0.401 ± 0.012 ms 0.991
utils/string_tree/preserve_sharing 0.542 ± 0.017 ms 0.544 ± 0.012 ms 0.996
time_to_load 0.227 ± 0.0066 s 0.227 ± 0.0015 s 0.999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants