Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting rid of question mark warning flags under components #208

Closed
sulli365 opened this issue Feb 22, 2022 · 9 comments
Closed

Getting rid of question mark warning flags under components #208

sulli365 opened this issue Feb 22, 2022 · 9 comments

Comments

@sulli365
Copy link

How do get rid of the yellow warning flags under glyphs that are part of larger components?

These flags do not appear on isolated glyphs...see attached example.
gal3p-gal3-gal1p-gfp

Also while I'm here - is there a way to toggle whether or not the part names show up underneath their respective glyphs? Long names get cut off which is not very useful from a publication perspective...

@cjmyers
Copy link
Contributor

cjmyers commented Feb 22, 2022

The question marks indicate that no sequence has been assigned to the part. If you use SynBioHub to select a part with a sequence or manually add a sequence they will go away.

We don't have an option for changing the label formatting. Thanks for the suggestion, we will add this to our to do list. As a temporary fix, you can add a text box over top of the label, which if filled will cover the existing label and allow you to add your own.

@sulli365
Copy link
Author

sulli365 commented Feb 22, 2022 via email

@cjmyers
Copy link
Contributor

cjmyers commented Feb 24, 2022

SBH logins are easy to get, but I agree that using this for just diagrams is nice. Probably we should also have a feature to remove the warnings for images.

@sulli365
Copy link
Author

sulli365 commented Feb 24, 2022 via email

@zachsents
Copy link
Collaborator

Hey @sulli365 I'm working on debugging SBOLCanvas, did you happen to save the error message you received?

@sulli365
Copy link
Author

sulli365 commented Feb 24, 2022 via email

@zachsents
Copy link
Collaborator

Yes, that would be super helpful. I'm trying to reproduce the errors and having a hard time getting them intentionally.

@sulli365
Copy link
Author

sulli365 commented Mar 3, 2022 via email

@zachsents
Copy link
Collaborator

@sulli365 Thanks for the thorough response! I think you might be getting that error because you have an extra character in your sequence, like a space after the "a" or something like that. Double check that and it should solve your issue.

I agree the error messages are pretty intuitive, and these are being shown as a result of too few checks going on in the background as you draw your diagram. We're working on adding some better validation in the background so you never see any of these errors.

As for making publishable images, you should be able to export images even when the SBOL export is throwing errors, although I know this isn't ideal. Also, a workaround for the IDs being cut off is to add a text block with the full text you want to display, which you'll also have control over the size of.

Thanks for the feedback, always appreciated and keep it coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants