Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to use same HDF5 version as Matlab #208

Closed
KrisThielemans opened this issue Feb 23, 2019 · 1 comment
Closed

Need to use same HDF5 version as Matlab #208

KrisThielemans opened this issue Feb 23, 2019 · 1 comment
Assignees
Milestone

Comments

@KrisThielemans
Copy link
Member

As per #197 and also #129, it seems we can only avoid conflicts between HDF5 versions by using exactly the same version as Matlab. We therefore need to check that if we build with Matlab, we download the same HDF5 version and build with that (as we cannot use Matlab's HDF5 libraries).

Info from Mathworks

HDF5 library versions can be got from the MATLAB function,
[majnum,minnum,relnum] = H5.get_libversion()
Documentation link: https://www.mathworks.com/help/matlab/ref/h5.get_libversion.html

The code here illustrates how to call matlab (will need to use $(Matlab_MAIN_PROGRAM)). Here is an example for parsing the output (but the parsing there is far too complicated for what we need of course).

@KrisThielemans KrisThielemans added this to the v2.0 milestone Feb 23, 2019
@KrisThielemans KrisThielemans modified the milestones: v2.0, v2.1 Apr 3, 2019
KrisThielemans pushed a commit that referenced this issue Jun 21, 2019
- use version HDF5 1.8.12 on Windows if Matlab is being built (see #208). At the moment the version is hard-wired. However, this likely introduced a conflict with Python as it usually uses a more recent version of HDF5 (certainly the Anaconda version does)
- add a patch for HDF5 1.8.12 such that it compiles post VS 2013.
- introduce a HDF5_DOWNLOAD_VERSION variable
- introduce a HDF5_CMAKE_ARGS variable for use in the cmake files that depend on HDF5

This now works fine on Windows as far as I see. On Windows, we will need to have 2 separate builds for MATLAB or Python support unfortunately.
@KrisThielemans KrisThielemans modified the milestones: v2.1, v2.2 Oct 6, 2019
@KrisThielemans KrisThielemans modified the milestones: v3.0, v3.1 Mar 11, 2021
@KrisThielemans
Copy link
Member Author

won't fix as MATLAB support is on hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants