Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

fix(vue): collection vue mixin reactivity on computed value fixed #93 #94

Merged
merged 3 commits into from
Aug 1, 2019
Merged

fix(vue): collection vue mixin reactivity on computed value fixed #93 #94

merged 3 commits into from
Aug 1, 2019

Conversation

mnugter
Copy link
Collaborator

@mnugter mnugter commented Jul 24, 2019

No description provided.

@mnugter mnugter requested a review from barthje July 24, 2019 11:45
barthje
barthje suggested changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@barthje barthje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the functionality in a project of mine but sadly it doesn't seem to be reactive yet

@mnugter
Copy link
Collaborator Author

mnugter commented Aug 1, 2019

Fixed the implementation and I can now see it working, please re-review.

@mnugter mnugter merged commit 7e001f5 into release/1.1.1 Aug 1, 2019
@mnugter mnugter deleted the feature/#93 branch August 2, 2019 08:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barthje barthje barthje requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnugter @barthje