Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: set SESSION_COOKIE_SECURE = True #197

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 23, 2023

Overview

Hotfix setting SESSION_COOKIE_SECURE = True.

Warning
Unable to test on an environment that mirrors production.

Important
Target branch (which I created yesterday) https://github.com/TACC/Core-CMS-Custom/tree/release/apcd-prod-2022-11 is off 3a439ba.1

Note
Target branch changed after merge to essentially be release/apcd-prod-2022-11-plus-secure-cookie-hotfix. Details.

Related

Changes

  • added new setting

Testing

Target Branch

Confirm 3a439ba is the most recently deployed taccwma/apcd-cms tag.1

Portal Login Cookie

  1. In Chrome/ium DevTools > Application > Cookies
  2. Confirm "Secure" column for "sessionid" cookie is checked.

Any CMS Page

Confirm style on CMS pages is unchanged from https://txapcd.org/.

UI

Skipped.

Footnotes

  1. I think 3a439ba is the most recently deployed taccwma/apcd-cms tag. Reference. 2

@wesleyboar wesleyboar changed the title hotfix: SESSION_COOKIE_SECURE = True hotfix: set SESSION_COOKIE_SECURE = True Aug 23, 2023
@wesleyboar wesleyboar changed the base branch from main to release/apcd-prod-2022-11 August 23, 2023 15:17
@rstijerina rstijerina merged commit 6d6cbcb into release/apcd-prod-2022-11 Aug 23, 2023
@rstijerina rstijerina deleted the hotfix/mimic-core-cms-pr-695-for-apcd-prod-from-nov-2022 branch August 23, 2023 15:39
@wesleyboar
Copy link
Member Author

I did poorly naming branches.

So, after merge:

  1. I created branch release/apcd-prod-2022-11-plus-secure-cookie-hotfix from the merge commit.
  2. I deleted branch release/apcd-prod-2022-11.
  3. I re-created branch release/apcd-prod-2022-11 off of 3a439ba.

Thus, release/apcd-prod-2022-11-plus-secure-cookie-hotfix is what to deploy.

After this, we need to consider release strategy for CMS apps in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants