hotfix: set SESSION_COOKIE_SECURE = True #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
I am unavailable to test yet. I approve it because I don't anticipate an issue. And Django says it should be True (even though default it to False).
https://docs.djangoproject.com/en/3.2/ref/settings/#std-setting-SESSION_COOKIE_SECURE
|
If every CMS needs this, then this should also be done off on a branch off of v3.11.5 tag, so I can make a v3.11.6 release. Most sites are running v3.11. Core-CMS does not have a stable v3.12 yet. |
This was referenced Aug 22, 2023
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Aug 23, 2023
To get TACC/Core-CMS#695. If UI demo breaks, see TACC/Core-CMS#692.
wesleyboar
added a commit
to TACC/Core-CMS-Custom
that referenced
this pull request
Aug 23, 2023
- mimics TACC/Core-CMS#695 - alternative to #196
rstijerina
pushed a commit
to TACC/Core-CMS-Custom
that referenced
this pull request
Aug 23, 2023
- mimics TACC/Core-CMS#695 - alternative to #196
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Aug 23, 2023
- mimics TACC/Core-CMS#695 - alternative to #301
jarosenb
pushed a commit
to TACC/tup-ui
that referenced
this pull request
Aug 23, 2023
- mimics TACC/Core-CMS#695 - alternative to #301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Sets
SESSION_COOKIE_SECURE = Trueto resolve a flag set by an ISO security audit.Related
Testing
UI