Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WP-329 and bug/WP-330: Fixes for registration form #236

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

edmondsgarrett
Copy link
Contributor

Overview

Re-numbers superscript references on form + fixes validation on phone and email fields for contacts

Related

Changes

  • Removed unused superscripts 2, 3, and 4 from bottom of form and re-numbered 5, 6, and 7 to 2, 3, and 4
  • In regex used to validate phone numbers and email addresses for contacts, escaped - characters within character sets to prevent invalid regex from checking these fields at all

Testing

  1. Go to https://localhost:8000/register/request-to-submit/
  2. Scroll to the bottom of the form and confirm there are only 4 entries listed for superscript descriptions
  3. Confirm, in the form, that these descriptions correctly match where said superscripts are used (the first is used in the 'Type' drop down in the 'Organization' section of the form)
  4. Fill out the form, and once at Contacts, try putting malformed phone numbers and emails in at least two contact entries
  5. Confirm you cannot submit the form unless these fields are formatted correctly
  6. After submission, go to https://localhost:8000/administration/list-registration-requests/ and confirm your new record is on the listing and, via View Record, all data submitted shows up
  7. Now, on the same record, via Edit Record, re-test steps 4-6

UI

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Tested and working great!

Copy link
Collaborator

@mjames-uth mjames-uth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@edmondsgarrett edmondsgarrett merged commit e86b398 into main Oct 25, 2023
@edmondsgarrett edmondsgarrett deleted the task/WP-329-330--reg-form-fixes branch October 25, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants