View users add entity/jira wp 374 #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmtacc
requested review from
happycodemonkey,
edmondsgarrett and
sophia-massie
…re-CMS-Custom into viewUsers-add-entity/JIRA-WP-374
sophia-massie
requested changes
Nov 7, 2023
There was a problem hiding this comment.
Looks great! One thing I noticed that was missing is that the edit user modal needs to also change to pull the r.entity_name and have the title of that field be <dt class="c-data-list__key">Entity Organization</dt> to line up with other admin table and modal labels. It's blank right now.
sophia-massie
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added entity to initial table and to view user modal as requested
…
Related
…Changes
Updated get_users db query, modified table and modal by replacing org_name with entity_name
…
Testing
UI
…
