Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WP-381 and WP-382: Reg form updates #248

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

edmondsgarrett
Copy link
Contributor

Overview

A couple of updates for the registration form from our 11-09-23 testing session

Related

Changes

  • On entities, NAIC and License input fields are now text input fields w/ regex that only allows ints to be submitted
  • For state dropdown, removed all JS + CSS on this select to now show full state abbr + state name

Testing

  1. Go to https://localhost:8000/register/request-to-submit
  2. Fill out form, and ensure:
    • The state dropdown is now the same length as the fields above it, and displays the states as so: "[State abbr.] - [State name" i.e. "TX - Texas"
    • The NAIC and License fields on more than 1 entity entry only allow ints to be submitted
  3. Submit form, and on success, go to https://localhost:8000/administration/list-registration-requests and confirm your record shows up and has all info you submitted

UI

image
image

@edmondsgarrett edmondsgarrett changed the title Task/wp 381 382 reg form updates task/WP-381 and WP-382: Reg form updates Nov 10, 2023
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@mjames-uth mjames-uth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@edmondsgarrett edmondsgarrett merged commit faec59f into main Nov 10, 2023
@edmondsgarrett edmondsgarrett deleted the task/WP-381-382--reg-form-updates branch November 10, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants