test: v3.11.0 candidate #638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previously installed branch was merged to main.
- fix(fonts): fp-1891 add regular italic, also add black (#71) - feat(objects): warning about still-disabled o-site - feat(components): icon updates from Core-Portal - docs(trumps): comment about lifespan of u-empty - chore(elements): body margin 0 - feat(dist): commit dist for clients relying on it (#70) - chore: import dependencies in each pattern
In Core-Styles, icon CSS moved: trumps/icon → components cortal.icon.
J.R. and I agree a real CDN makes sense for Core-Styles, long-term. J.R. doesn't know about this temp solution yet. He'll have better idea.
No need to re-build Core-Styles since we have it's `dist/`. Related PR: TACC/Core-Styles#70
- Add core styles version setting. - Load core-styles from pseudo-CDN. - Use new CSS layer tech to load stylesheets.
…ompat-release' into task/v3.11.0-candidate
…styles-beyond-0.11.0--attempt-backwards-compat-release
The site.header.css is the only file with a FUNCTIONAL change. The rest are just updating a comment.
Long-neglected follow-up to #549.
…ompat-release' into task/v3.11.0-candidate
… task/v3.11.0-candidate
…styles-beyond-0.11.0--attempt-backwards-compat-release
…styles-beyond-0.11.0--attempt-backwards-compat-release
…ompat-release' into task/v3.11.0-candidate
…ompat-release' into task/v3.11.0-candidate
…ompat-release' into task/v3.11.0-candidate
This was referenced May 23, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A single branch to test all code planned for v3.11.0 but not in
mainbranch.✅ Closed because I tested and should get this to main the long way, starting with via #605.
Related / Changes
Includes:
Does Not Include:
Required By:
Requires:
Testing
Compare pages of:
migrate.v1_v2.css& https://txapcd.orgmainby other devsDemData, https://pprd.democratizing-site.tacc.utexas.edu & https://democratizingdata.ai❌ This will be tested via fix(demdata-cms): rename, update, fix Core-CMS-Custom#164.
TACC, https://dev.tup.tacc.utexas.edu/ & https://www.tacc.utexas.edu/❌ This will be tested via feat(tup-cms): core-cms v3.12.0-alpha tup-ui#232.
UI
Skipped. Too many sites. I am testing. Maybe I have a testing session for CMD to approve/reject deploy of each site.
Notes
Known Issues
Expected since v3.9.0 / Task/fp 1801 guides breadcrumbs headings #549. See v3.9.0 test session "Migration Steps".
The differences are from a bug I just fixed in fix(templates): bump home_portal <hN> levels #640.
The new purple accent color came in v3.10.0 via fe3c242. Many of the old sites are currently on v3.8 or v3.9. The color will change back to blue in v3.11+ if
TACC_CORE_STYLES_VERSION = 2.<hr>under an<h1>is pulled up too close underneath the<h1>; examples:The cause is a difference between
migrate.v1-v2.cssandsite.cssbottom margin for<h1>.site.css.Because APCD used v3.9 + 25 commits of v3.10.0 and custom table CSS and CSS copied from Core-Portal.
This bug is not fixed until Core-Styles v1.0, fix(fonts): fp-1891 add regular italic, also add black Core-Styles#71.
Expected since v3.9.0 / Task/fp 1801 guides breadcrumbs headings #549.
Expected since v3.10.0 / b462ea2 / https://github.com/TACC/Core-Styles/releases/tag/v0.11.0.
Expected since v3.10.0 / b462ea2 / https://github.com/TACC/Core-Styles/releases/tag/v0.11.0. Fixed via snippet on dev.
Ignoring, because it is only on one unused page (System). All other pages are custom styles (home) or CMS v1 styles. Standard accent color has changed from brown to purple to blue. TACC and Core are as they should be. Frontera retains brown, but its use is not standardized.
ProTX prod is simply old and wrong. The staging version is accurate.
This is a newly-discovered v3.9.0 bug. (APCD at v3.9.1+, has this bug.)
Expected since v3.10.0 / b462ea2 / https://github.com/TACC/Core-Styles/releases/tag/v0.10.0 because of
x-link'stext-underline-offset.