Item B-03526: As a Manager, I wold like to sort services in the servi… #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce management table The ServiceSpecification is implemented to provide sorting and pagination. The AbstracSpecification used a default 'lastModified' order by, which does not exist in the ServiceRepo. To prevent breakage, the the order by assignment was move into its own function, toPredicateDefaultQueryOrderBy(). This allows for the ServiceSpecification, as an exception, to not attempt to order by "lastModified" by overriding that new method.
ghost
approved these changes
Jun 21, 2018
Pull Request Test Coverage Report for Build 15
💛 - Coveralls |
Repeat the coverage fix for the ServiceController in all similar controllers. The FeatureProposalController seems to be inconsistent and used other names than "page" for its method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ce management table
The ServiceSpecification is implemented to provide sorting and pagination.
The AbstracSpecification used a default 'lastModified' order by, which does not exist in the ServiceRepo.
To prevent breakage, the the order by assignment was move into its own function, toPredicateDefaultQueryOrderBy().
This allows for the ServiceSpecification, as an exception, to not attempt to order by "lastModified" by overriding that new method.