Skip to content

Sprint6 b03633 Add "feedback" field to feature proposal to accept reason for reject action #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
6 commits merged into from
Aug 15, 2018
Merged

Sprint6 b03633 Add "feedback" field to feature proposal to accept reason for reject action #72

6 commits merged into from
Aug 15, 2018

Conversation

kaladay
Copy link
Contributor

@kaladay kaladay commented Aug 14, 2018

No description provided.

@kaladay kaladay requested review from a user and rladdusaw August 14, 2018 21:57
@coveralls
Copy link

coveralls commented Aug 14, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 99

  • 7 of 10 (70.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 72.627%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/edu/tamu/app/controller/FeatureProposalController.java 3 4 75.0%
src/main/java/edu/tamu/app/model/repo/impl/FeatureProposalRepoImpl.java 0 2 0.0%
Totals Coverage Status
Change from base Build 86: 0.1%
Covered Lines: 727
Relevant Lines: 1001
💛 - Coveralls

ghost
ghost suggested changes Aug 15, 2018
View reviewed changes
src/main/java/edu/tamu/app/model/FeatureProposal.java Outdated
private FeatureProposalState state;

@Column(nullable = true)
private String feedback;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move property feedback and its getter and setter into AbstractIdea. Remove it from FeatureProposal and Idea.

@ghost ghost merged commit 74f0156 into sprint6-staging Aug 15, 2018
@kaladay kaladay deleted the sprint6-b03633-feature_proposal-reject_reason branch August 27, 2018 15:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rladdusaw rladdusaw Awaiting requested review from rladdusaw

1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaladay @coveralls