Skip to content

remove json identity info from voters, multiple POJO with same id as… #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2018
Merged

remove json identity info from voters, multiple POJO with same id as… #83

merged 1 commit into from
Nov 28, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 16, 2018

… identity is not deserializable

@ghost ghost requested review from rladdusaw and doug-hahn November 16, 2018 14:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 157

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 76.243%
Totals Coverage Status
Change from base Build 155: 1.3%
Covered Lines: 767
Relevant Lines: 1006
💛 - Coveralls

@ghost ghost requested a review from jcreel November 16, 2018 17:37
doug-hahn
doug-hahn approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@doug-hahn doug-hahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed to local vagrant and ideas and feature proposals work

@doug-hahn doug-hahn merged commit 30d5c67 into master Nov 28, 2018
@ghost ghost deleted the feature-proposal-update-deserialization branch November 28, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rladdusaw rladdusaw Awaiting requested review from rladdusaw

@jcreel jcreel Awaiting requested review from jcreel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coveralls @doug-hahn @tamu-sad-iii