-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DID DHT method #240
Add DID DHT method #240
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 90.99% 90.92% -0.07%
==========================================
Files 67 69 +2
Lines 12648 13314 +666
Branches 1261 1340 +79
==========================================
+ Hits 11509 12106 +597
- Misses 1116 1183 +67
- Partials 23 25 +2
|
updated to use dns packets as per https://hackmd.io/-fBsfngHRpuJilwf5GY3Qg?both#DIDs-as-a-DNS-Packet cc: @csuwildcat @Nuhvi |
@decentralgabe convention for imports in this repo is:
anything i'm missing w.r.t. to imports @frankhinek ? |
ready to go pending final review/approval by @mistermoe @frankhinek |
@frankhinek any reservations on pulling this in? not sure what work you have in flight or what that will disrupt |
Just started review. Also asked @shamilovtim to take a look to see what might need to be done to ensure that the |
I'll be taking a peak at this ASAP 👍 related: TBD54566975/web5-wallet#166 |
@mistermoe @decentralgabe The changes in Before I reach out to the package maintainer, are either of you aware if there are plans to release/publish a new version. It isn't a blocker for this PRl, so I'll create an issue to track this so we don't forget to remove the patch if the package is ever updated. |
unaware, an issue to track would be good |
Signed-off-by: Frank Hinek <frankhinek@users.noreply.github.com>
…r Web5 JS packages. Return boolean on publish. Signed-off-by: Frank Hinek <frankhinek@users.noreply.github.com>
Signed-off-by: Frank Hinek <frankhinek@users.noreply.github.com>
Signed-off-by: Frank Hinek <frankhinek@users.noreply.github.com>
Signed-off-by: Frank Hinek <frankhinek@users.noreply.github.com>
Signed-off-by: Frank Hinek <frankhinek@users.noreply.github.com>
https://github.com/TBD54566975/did-dht-method