Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying feedback session: mark session name as mandatory field when copying feedback session #12652

Closed
cedricongjh opened this issue Dec 11, 2023 · 1 comment · Fixed by #12670
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources.

Comments

@cedricongjh
Copy link
Contributor

Description of feature/enhancement
When copying a feedback session, user is not notified why they are unable to copy the feedback session if the session name field is empty:
image

Let's append a * symbol after "Session Name", and display a red warning with an exclamation mark, stating "The field Session Name should not be empty," when the instructor clicks the field but leaves it empty, similar to #12617

@cedricongjh cedricongjh added a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources. labels Dec 11, 2023
Copy link

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

andreiyusupau added a commit to andreiyusupau/teammates that referenced this issue Dec 18, 2023
andreiyusupau added a commit to andreiyusupau/teammates that referenced this issue Dec 19, 2023
andreiyusupau added a commit to andreiyusupau/teammates that referenced this issue Dec 20, 2023
domlimm added a commit that referenced this issue Dec 23, 2023
…eld when copying feedback session (#12670)

* Fix Copying feedback session: mark session name as mandatory field when copying feedback session #12652

* Fix Copying feedback session: mark session name as mandatory field when copying feedback session #12652

* Fix Copying feedback session: mark session name as mandatory field when copying feedback session #12652

---------

Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
cedricongjh pushed a commit to cedricongjh/teammates that referenced this issue Feb 20, 2024
…datory field when copying feedback session (TEAMMATES#12670)

* Fix Copying feedback session: mark session name as mandatory field when copying feedback session TEAMMATES#12652

* Fix Copying feedback session: mark session name as mandatory field when copying feedback session TEAMMATES#12652

* Fix Copying feedback session: mark session name as mandatory field when copying feedback session TEAMMATES#12652

---------

Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources.
Projects
None yet
1 participant