Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10156] Clean up unused backend CSV generation code #10254

Merged
merged 4 commits into from
Jun 29, 2020

Conversation

xpdavid
Copy link
Contributor

@xpdavid xpdavid commented Jun 29, 2020

Part of #10156

Outline of Solution

  • Commits are straight-forward.

@xpdavid xpdavid added the s.ToReview The PR is waiting for review(s) label Jun 29, 2020
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@madanalogy madanalogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madanalogy madanalogy added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Jun 29, 2020
@xpdavid xpdavid merged commit a4293c3 into TEAMMATES:csv-migration Jun 29, 2020
xpdavid added a commit that referenced this pull request Jun 29, 2020
* clean up unused code in question/response details & attributes

* standardize getter/setter in question details

* fix bug where instructor can post comment for contrib question & refactor to make use of polymorphism in question details

* disallow participant comment on MSQ (follow V6)
xpdavid added a commit that referenced this pull request Jun 29, 2020
* clean up unused code in question/response details & attributes

* standardize getter/setter in question details

* fix bug where instructor can post comment for contrib question & refactor to make use of polymorphism in question details

* disallow participant comment on MSQ (follow V6)
xpdavid added a commit that referenced this pull request Jun 29, 2020
* clean up unused code in question/response details & attributes

* standardize getter/setter in question details

* fix bug where instructor can post comment for contrib question & refactor to make use of polymorphism in question details

* disallow participant comment on MSQ (follow V6)
xpdavid added a commit that referenced this pull request Jun 29, 2020
* clean up unused code in question/response details & attributes

* standardize getter/setter in question details

* fix bug where instructor can post comment for contrib question & refactor to make use of polymorphism in question details

* disallow participant comment on MSQ (follow V6)
wkurniawan07 pushed a commit that referenced this pull request Jun 30, 2020
* clean up unused code in question/response details & attributes

* standardize getter/setter in question details

* fix bug where instructor can post comment for contrib question & refactor to make use of polymorphism in question details

* disallow participant comment on MSQ (follow V6)
@wkurniawan07 wkurniawan07 added this to the V7.0.0-rc.0 milestone Jun 30, 2020
yook0530 pushed a commit to edwardkang0925/teammates that referenced this pull request Jul 3, 2020
…TES#10254)

* clean up unused code in question/response details & attributes

* standardize getter/setter in question details

* fix bug where instructor can post comment for contrib question & refactor to make use of polymorphism in question details

* disallow participant comment on MSQ (follow V6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants