-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#10156] Clean up unused backend CSV generation code #10254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor to make use of polymorphism in question details
xpdavid
force-pushed
the
10156-clean-code
branch
from
June 29, 2020 01:38
537795e
to
f459642
Compare
wkurniawan07
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
madanalogy
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
madanalogy
added
s.ToMerge
The PR is approved by all reviewers including final reviewer; ready for merging
and removed
s.ToReview
The PR is waiting for review(s)
labels
Jun 29, 2020
xpdavid
added a commit
that referenced
this pull request
Jun 29, 2020
* clean up unused code in question/response details & attributes * standardize getter/setter in question details * fix bug where instructor can post comment for contrib question & refactor to make use of polymorphism in question details * disallow participant comment on MSQ (follow V6)
xpdavid
added a commit
that referenced
this pull request
Jun 29, 2020
* clean up unused code in question/response details & attributes * standardize getter/setter in question details * fix bug where instructor can post comment for contrib question & refactor to make use of polymorphism in question details * disallow participant comment on MSQ (follow V6)
xpdavid
added a commit
that referenced
this pull request
Jun 29, 2020
* clean up unused code in question/response details & attributes * standardize getter/setter in question details * fix bug where instructor can post comment for contrib question & refactor to make use of polymorphism in question details * disallow participant comment on MSQ (follow V6)
xpdavid
added a commit
that referenced
this pull request
Jun 29, 2020
* clean up unused code in question/response details & attributes * standardize getter/setter in question details * fix bug where instructor can post comment for contrib question & refactor to make use of polymorphism in question details * disallow participant comment on MSQ (follow V6)
wkurniawan07
pushed a commit
that referenced
this pull request
Jun 30, 2020
* clean up unused code in question/response details & attributes * standardize getter/setter in question details * fix bug where instructor can post comment for contrib question & refactor to make use of polymorphism in question details * disallow participant comment on MSQ (follow V6)
yook0530
pushed a commit
to edwardkang0925/teammates
that referenced
this pull request
Jul 3, 2020
…TES#10254) * clean up unused code in question/response details & attributes * standardize getter/setter in question details * fix bug where instructor can post comment for contrib question & refactor to make use of polymorphism in question details * disallow participant comment on MSQ (follow V6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10156
Outline of Solution