Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#10902] Skip 'session closed' email if already submitted #10914

Merged
merged 8 commits into from
Feb 2, 2021
Merged

[#10902] Skip 'session closed' email if already submitted #10914

merged 8 commits into from
Feb 2, 2021

Conversation

daongochieu2810
Copy link
Contributor

Fixes #10902

Same implementation as #10906

madanalogy
madanalogy requested changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@madanalogy madanalogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be some new discussion on the issue, perhaps we could wait until it is resolved

src/main/java/teammates/logic/api/EmailGenerator.java Outdated Show resolved Hide resolved
@madanalogy madanalogy added s.Ongoing The PR is being worked on by the author(s) s.OnHold The issue/PR's validity has been put on hold pending some other event labels Jan 18, 2021
@madanalogy madanalogy removed the s.OnHold The issue/PR's validity has been put on hold pending some other event label Jan 20, 2021
@madanalogy madanalogy added s.FinalReview The PR is ready for final review and removed s.Ongoing The PR is being worked on by the author(s) labels Jan 25, 2021
madanalogy
madanalogy approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@madanalogy madanalogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ChooJeremy
ChooJeremy approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@ChooJeremy ChooJeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github is confusing me, it says the function you edited was generateFeedbackSessionEmailBaseForInstructorReminders but that's not true, wonder why it's wrong.

src/test/java/teammates/ui/webapi/FeedbackSessionClosedRemindersActionTest.java Outdated Show resolved Hide resolved
@ChooJeremy ChooJeremy added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jan 31, 2021
@madanalogy madanalogy added the c.Feature User-facing feature; can be new feature or enhancement to existing feature label Feb 2, 2021
@madanalogy madanalogy removed the request for review from ccyccyccy February 2, 2021 08:45
@madanalogy madanalogy added this to the V7.10.0 milestone Feb 2, 2021
@madanalogy madanalogy merged commit 96408a3 into TEAMMATES:master Feb 2, 2021
@madanalogy madanalogy mentioned this pull request Feb 28, 2021
Closed
@wkurniawan07 wkurniawan07 mentioned this pull request Mar 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madanalogy madanalogy madanalogy approved these changes

@ChooJeremy ChooJeremy ChooJeremy approved these changes

Assignees

@ChooJeremy ChooJeremy

@madanalogy madanalogy

Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V7.10.0
Development

Successfully merging this pull request may close these issues.

Skip 'session closed' emails if already submitted
3 participants
@daongochieu2810 @ChooJeremy @madanalogy