-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#10979] Highlight today date and add today button #10980
[#10979] Highlight today date and add today button #10980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bug here. The following and previous month's dates are hidden even though they are supposed to muted only.
Before | After |
---|---|
We should also consider the styling of today's date in the edge case where it appears as a "following month" on the currently viewed month.
Also, I find that the today date highlight and the currently selected date highlight are too similarly styled. Maybe we can use something similar to the image below? Another advantage is that we can combine their styles if today's date is the selected date.
src/web/app/components/session-edit-form/session-edit-form.component.html
Outdated
Show resolved
Hide resolved
<div class="col-md-7 col-xs-center"> | ||
<div class="input-group"> | ||
<input id="submission-start-date" type="text" class="form-control" ngbDatepicker [ngModel]="model.submissionStartDate" (ngModelChange)="triggerModelChange('submissionStartDate', $event)" #startTimeDp="ngbDatepicker" [disabled]="!model.isEditable"/> | ||
<ng-template #ft1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change name similarly for ft1
, ft2
, ft3
and ft4
.
If possible, can try passing in the parameter for the model change without repeating the footer template 4 times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its possible with a custom template. But not possible with [footerTemplate]
directive and without using it the Today button will not appear inside the datepicker
src/web/app/components/session-edit-form/session-edit-form.component.ts
Outdated
Show resolved
Hide resolved
Did you try using |
That does not seem to work on the |
You probably have to put it in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/web/app/components/session-edit-form/session-edit-form.component.html
Outdated
Show resolved
Hide resolved
…eu2810/teammates into hieu/datepicker-tweaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #10979
Outline of Solution
ng-template