[#10569] Missing loading icons and bugs for session edit form

[jfrairigh]

Part of #10569

Outline of Solution

I found the HTML page for the session edit form and added directives to each button to turn the spinner component on and off based on boolean values. I then went to methods of the corresponding action (delete, cancel, etc.) and boolean variables to determine if the action was still in progress. The top save button was slightly different. Someone had already added the directive. However, the save button was being deleted before the save processed had finished. I changed the HTML code to ensure the button remained throughout the saving processes.

[moziliar]

Hi, can you show some screenshot of the before/after change view? This way, it is easier to view the direct impact of the intended changes.

[jfrairigh]

Here is a before video:
https://drive.google.com/file/d/1OajHFXMoDhwY5YAMTyky9_yD1sxjDqDe/view?usp=sharing

Here some after screenshots:
https://drive.google.com/file/d/1K_8a5zzV4VkIbe5xbap_vCa7EmGOwwu1/view?usp=sharing

[jfrairigh]

@moziliar This should be ready for review now. Let me know if you need anything else from me.

[moziliar]

Thank you for your contribution!

I am not sure if this PR is linked to the right issue/PR as I cannot elicit any context from the target page. Could you check it again? Otherwise, could you fill me in with some context?

I think the spinners should be great to have.

However, the save button was being deleted before the save processed had finished.

Maybe add a slower version of this scene could be snipped for reference? The video doesn't show a UX flaw induced by this effect.

[moziliar]

Do revert the package-lock.json file that is modified, probably due to an npm install that updates the hash.
Otherwise, this PR LGTM!

[moziliar]

LGTM. The changes are clean.

[moziliar]

Some tips about the revert process is that:
You could perform git reset --soft HEAD^, git reset, git add <only the necessary files>, git commit, git push -f to overwrite the last commit you had. In this case, I think it'd be squashed so it would not matter.

[jfrairigh]

Thank you for the advice on the revert process. I will keep that in mind for next time. Sorry for the excessive commits.

[moziliar]

Do note that try not to overwrite the history that is in used elsewhere, e.g. in collab branch or the branch is in use elsewhere, in which case a revert commit is a wiser choice, albeit the extra commit.

[madanalogy]

LGTM