Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5704] Standardize You vs I in UI #11035

Merged
merged 6 commits into from
Apr 12, 2021

Conversation

frankelsf
Copy link
Contributor

Fixes #5704

Changed phrasing of specific template questions on relevant pages to match the following updates-

Question 1: Please rate the estimated contribution of your team members and yourself.
-> How much work did each team member contribute? (response will be shown anonymously to each team member).
Question 2: Comments about your contribution (shown to other teammates)
-> What contributions did you make to the team? (response will be shown to each team member).

Question 3: Your comments about this teammate (confidential and only shown to instructor)
-> What comments do you have regarding each of your team members? (response is confidential and will only be shown to the instructor).

Question 4: Comments about team dynamics (confidential and only shown to instructor)
-> How are the team dynamics thus far? (response is confidential and will only be shown to the instructor)

Question 5: Your feedback to this teammate (shown anonymously to the teammate)
-> What feedback do you have for each of your teammates? (response will be shown anonymously to each teammate)

Copy link
Contributor

@moziliar moziliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The changes are as discussed. And those places are the only ones that contain thees texts.

Please do fix up the broken e2e tests before final evaluation. Good job!

@moziliar moziliar self-assigned this Mar 17, 2021
@moziliar moziliar added the s.Ongoing The PR is being worked on by the author(s) label Mar 17, 2021
@moziliar moziliar added s.FinalReview The PR is ready for final review and removed s.Ongoing The PR is being worked on by the author(s) labels Apr 6, 2021
Copy link
Contributor

@moziliar moziliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moziliar moziliar requested a review from madanalogy April 6, 2021 15:01
@daongochieu2810 daongochieu2810 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Apr 7, 2021
Copy link
Contributor

@madanalogy madanalogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@madanalogy madanalogy changed the title [#5704] first commit Standardize you vs I in UI [#5704] Standardize You vs I in UI Apr 12, 2021
@madanalogy madanalogy self-assigned this Apr 12, 2021
@madanalogy madanalogy added the c.Feature User-facing feature; can be new feature or enhancement to existing feature label Apr 12, 2021
@madanalogy madanalogy added this to the V7.15.0 milestone Apr 12, 2021
@madanalogy madanalogy merged commit 57b1b74 into TEAMMATES:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize 'you' vs 'I' in UI
4 participants