Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#10433] Instructor view results: Use fixed-width floating numbers #11059

Merged
merged 3 commits into from
Apr 13, 2021
Merged

[#10433] Instructor view results: Use fixed-width floating numbers #11059

merged 3 commits into from
Apr 13, 2021

Conversation

DanielMcBane
Copy link
Contributor

Fixes #10433

I added ().toFixed(2) to lines 65, 82, and 83. This causes the value returned to always go to two decimal places e.g. 1 -> 1.00, 2.1 -> 2.10, 3.222 -> 3.22, etc.
two_decimal_places

Derek-Hardy
Derek-Hardy approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@Derek-Hardy Derek-Hardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Derek-Hardy Derek-Hardy self-assigned this Mar 23, 2021
@Derek-Hardy Derek-Hardy added the s.FinalReview The PR is ready for final review label Mar 23, 2021
ccyccyccy
ccyccyccy reviewed Mar 26, 2021
View reviewed changes
Copy link
Contributor

@ccyccyccy ccyccyccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we don't need the paranthesis to call toFixed()?

@DanielMcBane
Copy link
Contributor Author

I am not certain if the parentheses are necessary, I will try it without the parentheses some time in the next day or two.

@madanalogy madanalogy added s.Ongoing The PR is being worked on by the author(s) and removed s.FinalReview The PR is ready for final review labels Apr 4, 2021
@DanielMcBane
Copy link
Contributor Author

parentheses_needed
After further testing, it appears to me that the parentheses are needed.

@Derek-Hardy Derek-Hardy added s.FinalReview The PR is ready for final review and removed s.Ongoing The PR is being worked on by the author(s) labels Apr 8, 2021
madanalogy
madanalogy approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@madanalogy madanalogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@madanalogy madanalogy added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Feature User-facing feature; can be new feature or enhancement to existing feature and removed s.FinalReview The PR is ready for final review labels Apr 12, 2021
@madanalogy madanalogy added this to the V7.15.0 milestone Apr 12, 2021
@madanalogy madanalogy self-assigned this Apr 12, 2021
@madanalogy madanalogy merged commit 9d500ae into TEAMMATES:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madanalogy madanalogy madanalogy approved these changes

@Derek-Hardy Derek-Hardy Derek-Hardy approved these changes

@ccyccyccy ccyccyccy Awaiting requested review from ccyccyccy

Assignees

@Derek-Hardy Derek-Hardy

@madanalogy madanalogy

Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V7.15.0
Development

Successfully merging this pull request may close these issues.

Instructor view results: Use fixed-width floating numbers
4 participants
@DanielMcBane @ccyccyccy @Derek-Hardy @madanalogy