[#11020] Remove searching response comments related features and search box at home page

[wkurniawan07]

First part of #11020

This removes all code related to searching response comments as well as the search box at the top of instructor home page.

This will also close #3918, close #8704, close #9103 since they are all irrelevant without the searching response comments feature.

[Derek-Hardy]

LGTM!

[Derek-Hardy]

Is there a good reason to remove the home search bar?

Understand it's just a redirection to the search page. From the UX perspective, this removal makes search operation become two-steps-away from login.

If search is a frequent action performed by the instructor, it will be convenient to make it immediately available at home page?

[wkurniawan07]

A search bar at home page heavily implies a site-wide search, which this search bar is nothing about. There are multiple cases of such mis-usage, like "how do I publish a session", "how do I enroll students", etc.

[jianhandev]

Agree that the search bar was a bit out of place on the homepage, esp. since we already have a search page. However, I still think that the current search bar is not explicit enough as to what is searchable and what is not. I believe we can address that in a new issue or after the search migration.

[wkurniawan07]

[jianhandev]

There are still some mention of search comments feature in the following files:

• features-page.component.html (line 212)
• instructor-search-page.component.ts (line 42)

[wkurniawan07]

@jianhandev I will merge after your approval

[jianhandev]

LGTM!