[#11020] Make search service optional and remove App Engine Search API usage #11067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/e2e/java/teammates/e2e/cases/BaseE2ETestCase.java # src/e2e/java/teammates/e2e/cases/InstructorHomePageE2ETest.java # src/e2e/java/teammates/e2e/pageobjects/InstructorSearchPage.java # src/main/java/teammates/common/util/Const.java # src/main/java/teammates/storage/search/SearchDocument.java # src/test/java/teammates/test/GaeSimulation.java # src/test/java/teammates/test/TestProperties.java # src/test/resources/test.template.properties
Derek-Hardy
reviewed
Mar 27, 2021
| private SearchManager() { | ||
| // utility class | ||
| private boolean isSearchServiceActive() { | ||
| return !StringHelper.isEmpty(searchServiceHost); | ||
| } |
There was a problem hiding this comment.
Contrary to the TestProperties counterpart, return value of this function will always be negated.
How about isSearchServiceInactive()?
There was a problem hiding this comment.
@Derek-Hardy I'll leave this to later edit, if absolutely necessary
| @SuppressWarnings("PMD.NonThreadSafeSingleton") // ok to ignore as method is only invoked at application startup | ||
| public static void registerSearchManager(SearchManager searchManager) { | ||
| if (instance == null) { | ||
| instance = searchManager; |
There was a problem hiding this comment.
Any reason for null check? Intuitively the registration should overwrite whatever the old instance.
There was a problem hiding this comment.
The instance is final and should not be changed once set in the entire application lifecycle. Since using final obviously will not work here, this is the best alternative.
wkurniawan07
added
s.ToMerge
wkurniawan07
added a commit
that referenced
this pull request
Apr 12, 2021
wkurniawan07
added a commit
that referenced
this pull request
Apr 12, 2021
wkurniawan07
added a commit
that referenced
this pull request
Apr 28, 2021
wkurniawan07
added a commit
that referenced
this pull request
May 3, 2021
wkurniawan07
added a commit
that referenced
this pull request
Jun 2, 2021
wkurniawan07
added a commit
that referenced
this pull request
Jun 6, 2021
wkurniawan07
added
c.Task
wkurniawan07
added a commit
that referenced
this pull request
Jun 6, 2021
daongochieu2810
pushed a commit
to daongochieu2810/teammates
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #11020
storage.searchpackage only.SearchNotImplementedException. The latter will be translated to501 Not Implementedstatus at API layer.com.google.appengine.api.searchpackage in the code base.